Repository navigation
feat(web): the scheduled task editor uses the new-thread composer layout - #1030
Merged
Merged
Conversation
…layout The scheduled task form was a long settings page. It is now laid out like the new-thread screen (#1019): "New task in [project]", the composer's box with the task name and one schedule button on top, the prompt, the real model and access buttons and Create task (Save when editing). A sentence under the box says where each run goes, with a menu in each part: a new thread or one to continue (and the room agent), the local checkout or a new worktree, and the computer. The schedule button opens the repeat pattern, day, time and next runs, with the time zone, a custom cron rule (started from the schedule picked so far) and event triggers one step further in. Event settings sit under the sentence, unchanged. Shared pieces moved out for reuse: the dotted inline picker trigger (also on the new-thread heading), the composer's box class, and the model button's effort summary.
- One save at a time, so a double Cmd/Ctrl+Enter creates one task. - The access button shows the level the task saves, not the one its agent offers today. - A draft whose computer disconnected can still move to another one. - Switching to a new thread and back keeps the continued thread's agent, model and access, and the saved thread stays listed when it's older than the recent ones or archived. - Keyboard focus follows the schedule popover's time zone page and back. - The schedule button follows the app's 12/24-hour setting. - The fixed computer name keeps its hint as a hover label.
- The schedule is checked against the current moment on every change and again at save, so a one-time time that just passed is never sent. - The instructions hint is a visible line again, under the where-it-runs sentence, so it shows once the prompt has text. - The access button shows the level the agent runs at, as on the composer. - The effort meter marks the model's default level with a small dot (and says so on hover and to screen readers), as the old traits menu's "default" tag did. - Tests: a save shortcut pressed while the create is still out sends nothing more, and switching to a new thread and back keeps the continued thread's access.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1019.
The scheduled task editor was a long settings-style form. It now looks like starting a thread: a "New task in [project]" heading, then a box with the task name, one schedule button ("Weekdays at 9:00 AM"), the prompt, the composer's own model and access buttons, and Cancel / Create task (Save when editing). Under the box, a sentence of inline menus says where each run goes ("Each run starts [a new thread] in [the local checkout] on [computer]"), followed by the instructions hint and the next run. The schedule button opens a popover with repeat, time and next runs. Time zone, a custom cron rule and event triggers sit one step further in. Event tasks keep their full settings in a "When it runs" group under the box.
Every option, hint, validation and default from the old form is kept. The build started from an inventory of the old form, mapping each option to its new place, and a separate pass compared the two. Pause, Resume and Delete stay on the task page. Plan mode isn't offered, as before.
One intended change: "Custom cron rule" now starts from the schedule picked so far (Weekly on Friday at 9:00 becomes
0 9 * * 5). The old form always started from0 9 * * 1-5.Shared pieces: an inline picker for the dotted menus (also used by the new-thread heading, which gains a keyboard focus ring), the composer box class, and the model button summary moved into traitControls. The effort meter marks a model's default level with a small dot, which also shows in the chat composer.
Review fixes from GPT-6.2 Astra: Cmd/Ctrl+Enter can't start a second save while one is running; switching between new and continued thread keeps the thread's agent, model and access; a draft on a computer that disconnects can move to another; one-time times are checked against the current time on change and on save; the instructions hint stays visible.
Checked: fmt, lint, typecheck, scheduled unit tests, event-tasks browser spec, full web browser suite (1160/1160), polish check in light and dark on desktop and phone.